-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit f32ca0b causes markdowncv themes to break? #261
Comments
Thanks for the thorough investigation @monicathieu! |
Hi! Thank you @mitchelloharawild for this super helpful package and @monicathieu for tracking down the error. I get the same warnings with this setup in Emacs with ESS:
Please let me know if there's anything I can do to help fix this. I'm not sure why the files for the fonts, etc. aren't located in the expected locations. |
I updated vitae to 0.6.0 because I was excited to try Colton Baumler's new ccbaumler theme for the markdowncv format. However, my previously rendering CV (using the davewhipp theme) suddenly started to render to a "plain" R Markdown and the theming fails to apply! I haven't changed anything on my CV Rmd.
Also, the following pandoc warnings are now showing up on the Render tab:
This suggests pandoc is failing to find the theme CSS paths, but I sadly don't don't know enough about how vitae calls knitr and pandoc under the hood to know what exactly the issue is.
I have narrowed it down to something in commit f32ca0b, which definitely suggests it's a knitr-to-pandoc issue of some sort. The theme appears correctly when I reinstall vitae on the previous commit (no changes to the Rmd file or anything else).
Annoyingly, the previous commit has that duplication issue the offending commit fixes. I saw some comments in #254 suggesting the duplication was arising from a knitr update, but I checked through several package versions and I actually think it came from the xfun 0.44 update--maybe because
xfun::write_utf8()
now returnscon
, not NULL? I did confirm that the theme-less CV knitted after commit f32ca0b does not duplicate the CV contents.Relevant version info:
R 4.3.1
pandoc 3.1.11
knitr 1.47 (but this issue also happens with 1.43)
rmarkdown 2.25
The text was updated successfully, but these errors were encountered: