-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiny enhancement: make favicon an option #345
Comments
I agree on making the favicon configurable via a CLI switch, not sure what's the best way to address it and what the default value should be1. A couple of options:
Happy to hear what others are thinking! Footnotes
|
I vote for (2) as the simplest to understand, and also matching the behavior of the existing logo option. Default value is a good question. You could just leave it blank, and let the browser show its 'no icon' value in that case. |
I didn't consider the consistency with Leaving it blank by default sounds good to me as well. Please feel free to send a PR! 😃 |
I will be happy to do that! |
This is now fixed in pdoc 10, thanks again! 🍰 |
Problem Description
You can currently replace the favicon for a site by modifying the default frame template. IMO, users are unlikely to need to modify this template for other reasons, but likely to want to have a custom favicon.
Proposal
Make favicon an option ala logo.
I would be happy to do this work, if it seems worthwhile to do so.
The text was updated successfully, but these errors were encountered: