Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CKEditor & remove deprecated webpack integration #2054

Open
2 tasks
ChristopherChudzicki opened this issue Jan 2, 2024 · 0 comments
Open
2 tasks

Comments

@ChristopherChudzicki
Copy link
Contributor

ChristopherChudzicki commented Jan 2, 2024

Description/Context

We should:

  • Update CKEditor to a newer version, probably the latest
    • Studio uses v35 and community provided typescript definitions. CKEditor has first-class support for Typescript starting in v38, so we should remove the community provided type definitions.
  • Stop using @ckeditor/ckeditor5-dev-webpack-plugin, which is deprecated.

Plan/Design

For updating the webpack integration, the CKEditor5 guide Integrating from source using webpack describes what to do. See also implementation in MIT Open.

One issue is that starting in v39, CKEditor includes some small branding. See Managing the “Powered by CKEditor” logo. Here's one way to remove it. Or we could leave it, since Studio is just internal anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant