Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show Safari compatability warning for Safari 13 and below #306

Closed
isaisabel opened this issue Jun 15, 2021 · 1 comment · Fixed by #329
Closed

Only show Safari compatability warning for Safari 13 and below #306

isaisabel opened this issue Jun 15, 2021 · 1 comment · Fixed by #329
Assignees
@iguannalin
Labels
bug Something isn't working Points: 2 2 agile story points priority/high High priority Issue timescale/imminent Ready to be assigned to developers
Milestone
Version 4.4

Comments

@isaisabel
Copy link
Contributor

As a user, I want to be warned of compatibility issues but only for the version of the browser affected by the issue. The current safari warning only applies to Safari 13 and below, but it appears for all versions of the browser.

See this code for an example of getting the browser version from the userAgent.
@isaisabel isaisabel added bug Something isn't working priority/high High priority Issue timescale/imminent Ready to be assigned to developers labels Jun 15, 2021
@isaisabel isaisabel added this to the Version 4.4 milestone Jun 15, 2021
@isaisabel
Copy link
Contributor Author

We will also need to revise any documentation mentioning the safari compatibility to mention the specific non-compatible versions. See #262 for the PR that removed Safari support originally.

@isaisabel isaisabel added the Points: 2 2 agile story points label Jun 24, 2021
@iguannalin iguannalin self-assigned this Aug 4, 2021
@iguannalin iguannalin linked a pull request Aug 4, 2021 that will close this issue
Added check for if Safari version is 13. and below to show incompatibility warning dialog #329
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iguannalin iguannalin

Labels
bug Something isn't working Points: 2 2 agile story points priority/high High priority Issue timescale/imminent Ready to be assigned to developers
Projects
None yet
Milestone
Version 4.4
2 participants
@isaisabel @iguannalin