Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation of pad distance in LandFireLatLongBox init insufficient for large map sizes #29

Open
afennelly-mitre opened this issue May 24, 2024 · 0 comments
Labels
bug Something isn't working operational Having to do with operational data planned The project team will work on this issue version:patch Updating the patch version x.x.(x + 1)

Comments

@afennelly-mitre
Copy link
Contributor

In commit 7466bde, we introduced the pad_distance attribute to the LandFireLatLongBox class. The pad_distance uses a fixed constant of 100 to pull "extra data" from landfire to ensure that the resulting fuel.shape is equivalent to the user provided area.screen_size tuple.

However, this does not work when using larger map sizes, ie. there is an upper bound when using 100 where if the area.screen_size is above this upper bound, the resulting fuel.shape is no longer equivalent to the provided fuel.shape.

I haven't tested this rigorously to discover the true upper bound, but I have found that setting the constant to 250 upholds the equivalent shape assumption for map sizes less than or equal to (768, 768).

@doyled-it doyled-it added operational Having to do with operational data version:patch Updating the patch version x.x.(x + 1) bug Something isn't working planned The project team will work on this issue labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working operational Having to do with operational data planned The project team will work on this issue version:patch Updating the patch version x.x.(x + 1)
Projects
None yet
Development

No branches or pull requests

2 participants