Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation typo #82

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Fix documentation typo #82

merged 1 commit into from
Jan 20, 2021

Conversation

spenserblack
Copy link
Contributor

targert ➡️ target

@spenserblack spenserblack changed the title Fix typo Fix documentation typo Jan 20, 2021
@pksunkara pksunkara merged commit cc3fcc1 into console-rs:master Jan 20, 2021
@spenserblack spenserblack deleted the patch-1 branch January 20, 2021 18:06
This was referenced Mar 15, 2021
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
dtolnay pushed a commit to dtolnay-contrib/console that referenced this pull request Feb 4, 2022
@hawkw
fix(console): stop truncating task fields column (console-rs#82)
1abf13d 
Currently, there's a bug where the console's task list view truncates
the fields column to the first ten characters, even when there are
characters remaining in the window to display more of the fields column.
This is due to `tui`'s layout constraints system apparently choosing to
give that column only the minimum number of characters specified,
instead of giving it all the remaining characters not used by other
columns.

I couldn't figure out how to get `tui` to actually do what we want
(there doesn't seem to be a `Constrait` for saying "use any remaining
characters not needed for satisfying previous layout constraints"), so I
just kind of hacked around it by adding up all the other columns,
subtracting their widths from the total width of the window, and
specifying that as a "minimum" constraint.

This is kinda ugly, but it seems to work.

### Before:
![image](https://user-images.githubusercontent.com/2796466/128217907-81ec6ed0-2282-4c7a-98b2-6773dd4888f5.png)

### After:
![image](https://user-images.githubusercontent.com/2796466/128218221-71c7ec6c-303f-448c-8374-eef0785ab1c3.png)


Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksunkara pksunkara pksunkara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spenserblack @pksunkara