You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is from an assert_snapshot! in web/book/tests/examples/book.rs with a snapshot name of introduction/0.
Given that the snapshots are already in the path examples, is there a reason to prefix the filename of the snapshot with examples__? Could the name of the snapshot instead just be:
One option is to write new snapshots with the shorter name while supporting older snapshots with longer names.
It would be technically possible to have conflicts, but extremely unlikely (in the example above, we'd need a module web/book/tests/examples/examples/book.rs containing a test with exactly the same name, and the new module would have to write with the new naming scheme, while the old module remains on the existing naming scheme).
This might be too much of a breaking change, or I might be misunderstanding the structure, but: we current have snapshots at a path like:
This is from an
assert_snapshot!
inweb/book/tests/examples/book.rs
with a snapshot name ofintroduction/0
.Given that the snapshots are already in the path
examples
, is there a reason to prefix the filename of the snapshot withexamples__
? Could the name of the snapshot instead just be:The text was updated successfully, but these errors were encountered: