Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ord implementation #585

Closed
mitsuhiko opened this issue Sep 6, 2024 · 1 comment
Closed

Ord implementation #585

mitsuhiko opened this issue Sep 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mitsuhiko
Copy link
Owner

mitsuhiko commented Sep 6, 2024 •
edited
Loading

This crate currently abuses Ord to get the sorting functions to work on arbitrary keys. Starting with Rust 1.81 this can/will crash the sort function. Consequently the PartialOrd and Ord implementations of the key will need to be adjusted.

See rust-lang/rust#129561
@mitsuhiko mitsuhiko added the bug Something isn't working label Sep 6, 2024
@mitsuhiko
Copy link
Owner Author

Fixed by #586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mitsuhiko