Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heads up: removing convert_pair_to_loop() from gemmi #101

Open
wojdyr opened this issue May 27, 2024 · 0 comments
Open

heads up: removing convert_pair_to_loop() from gemmi #101

wojdyr opened this issue May 27, 2024 · 0 comments

Comments

@wojdyr
Copy link

wojdyr commented May 27, 2024

Hi,
I replaced a gemmi function that is used here:

freesasa/src/cif.cc

Lines 713 to 716 in 51a996d

if (!table.loop_item) {
// Table is a pair so turning it into a loop
table.convert_pair_to_loop();
}

with ensure_loop(). Sorry about this. This is the only github project that uses this function (from what I found in github search), so I didn't leave the old name for backward compatibility.
These 4 lines can be replaced with table.ensure_loop();, or perhaps table.erase() can be used instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant