Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set default chart version if version is not set #225

Open
Magic-Mayo opened this issue Jan 22, 2025 · 0 comments
Open

Do not set default chart version if version is not set #225

Magic-Mayo opened this issue Jan 22, 2025 · 0 comments

Comments

@Magic-Mayo
Copy link

Magic-Mayo commented Jan 22, 2025

Currently, if you want to install or upgrade or template a chart and do not supply a version to use in the ChartSpec, a default version of >0.0.0-0 is set. This is the equivalent of using the helm install/upgrade/template command in the binary while also setting the --devel flag. This behavior can be dangerous if you're relying on the default being the latest stable version and not a prerelease version.

I propose the version just be left unset if not supplied. Leaving the version unset will skip prerelease versions as a viable candidate for the install/upgrade/template. Alternatively, adding a field in the ChartSpec that allows you to specify you would like to consider development versions of the chart instead of making that assumption could be an option.

https://github.com/mittwald/go-helm-client/blob/master/client.go#L300-L302
https://github.com/mittwald/go-helm-client/blob/master/client.go#L358-L360
https://github.com/mittwald/go-helm-client/blob/master/client.go#L490-L492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant