Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the GitHub Actions CI workflow to make it clearer and more reliable #407

Closed
pzhlkj6612 opened this issue Sep 27, 2021 · 3 comments
Labels
enhancement New feature or request no-issue-activity
Milestone

Comments

@pzhlkj6612
Copy link
Contributor

I found that our CI scripts (test-install-qt.yml and upload-release-artifacts.yml) will not create a continuous release when a push event occurs. The continuous release is only triggered when another release is created.

After re-reading all the scripts, I think we may need to re-design them. My expected workflow is as follows and this workflow should work with continuous build, prerelease and release:

  1. Check the code (style, quality, etc.).
  2. Build and test:
    • Build and test the Python package.
    • Build and test the standalone exe on Windows.
  3. If everything goes well, create a release, upload the standalone exe to this release, and upload the Python package to PyPI or Test PyPI (I think uploading the ".wheel" file to the release also makes some sense).

To implement the above workflow, we may need to use workflow_run in our scripts.

Please set the milestone of this issue to "future"; we need the version 2.0.0.

@miurahr miurahr added this to the future milestone Sep 27, 2021
@miurahr miurahr added the enhancement New feature or request label Sep 27, 2021
@pzhlkj6612
Copy link
Contributor Author

New objective: append the version number to the filename of the asset in non-continuous releases.

from: #404 (comment)

@miurahr miurahr modified the milestones: future, version 2.1 Sep 29, 2021
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-issue-activity
Projects
None yet
Development

No branches or pull requests

2 participants