Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: QT_EDITION might need to be modified to overcome QMake projects license check failure #802

Open
1 task done
IMAN4K opened this issue Jul 1, 2024 · 5 comments
Open
1 task done
Labels
bug Something isn't working help wanted Extra attention is needed need more information triage

Comments

@IMAN4K
Copy link

IMAN4K commented Jul 1, 2024

Bug description

license check error when dealing with QMake projects:

License check failed! Giving up...

Expected behavior

These lines:

QT_EDITION = Enterprise
QT_LICHECK = licheck.exe

Must be changed to:

QT_EDITION = OpenSource

Inside <architecture>/mkspecs/qconfig.pri for QMake projects to work correctly.

aqt and python version

v3.1.13 on Python 3.12.3 [CPython MSC v.1938 64 bit (AMD64)]

Operating System

Windows

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@IMAN4K IMAN4K added bug Something isn't working triage labels Jul 1, 2024
@miurahr miurahr added help wanted Extra attention is needed good first issue Good for newcomers and removed triage labels Jul 1, 2024
@miurahr
Copy link
Owner

miurahr commented Jul 1, 2024

From which Qt Version?
It works well until Qt 6.5.3 which is tested on CI environment.

@IMAN4K
Copy link
Author

IMAN4K commented Jul 1, 2024

@miurahr
I'm testing under 5.15.x which is supported

@miurahr
Copy link
Owner

miurahr commented Jul 1, 2024

when running

python -m aqt install-qt windows desktop 5.15.2 win64_msvc2019_64 --archives qtbase
INFO    : aqtinstall(aqt) v3.1.17.dev2 on Python 3.10.12 [CPython GCC 11.4.0]

it looks no problem.

$cat 5.15.2/msvc2019_64/mkspecs/qconfig.pri 
QT_ARCH = x86_64
QT_BUILDABI = x86_64-little_endian-lp64
QT.global.enabled_features = shared shared debug_and_release build_all c++11 c++14 c++17 c++1z thread futu
re concurrent signaling_nan
QT.global.disabled_features = cross_compile framework rpath appstore-compliant c++2a c99 c11 pkg-config fo
rce_asserts separate_debug_info simulator_and_device static
QT_CONFIG += shared shared debug_and_release debug release build_all c++11 c++14 c++17 c++1z concurrent db
us no-pkg-config stl
CONFIG += shared shared release no_plugin_manifest
QT_VERSION = 5.15.2
QT_MAJOR_VERSION = 5
QT_MINOR_VERSION = 15
QT_PATCH_VERSION = 2
QT_MSVC_MAJOR_VERSION = 19
QT_MSVC_MINOR_VERSION = 26
QT_MSVC_PATCH_VERSION = 28806
QT_EDITION = OpenSource
QT_LICHECK =
QT_RELEASE_DATE = 2020-11-12

When runnning

 python -m aqt install-qt windows desktop 6.8.0 win64_msvc2022_64 --archives qtbase
INFO    : aqtinstall(aqt) v3.1.17.dev2 on Python 3.10.12 [CPython GCC 11.4.0]

It is also no problem.

$ cat 6.8.0/msvc2022_64/mkspecs/qconfig.pri 
QT_ARCH = x86_64
QT_BUILDABI = x86_64-little_endian-lp64
QT_LIBCPP_ABI_TAG = 
QT.global.enabled_features = version_tagging shared debug_and_release c++20 c++2a signaling_nan thread future concurrent dbus opensslv30 shared intelcet shared debug_and_release c++20 c++2a openssl
QT.global.disabled_features = static cross_compile pkg-config separate_debug_info appstore-compliant simulator_and_device rpath force_asserts framework c++2b reduce_relocations wasm-simd128 wasm-exceptions zstd openssl-linked opensslv11
QT.global.disabled_features += release build_all
QT_CONFIG += shared no-pkg-config debug_and_release c++20 c++2a openssl release debug
CONFIG +=  shared plugin_manifest intelcet
QT_VERSION = 6.8.0
QT_MAJOR_VERSION = 6
QT_MINOR_VERSION = 8
QT_PATCH_VERSION = 0

QT_MSVC_MAJOR_VERSION = 19
QT_MSVC_MINOR_VERSION = 39
QT_MSVC_PATCH_VERSION = 33520

Please share exact procedure to reproduce the issue.

@miurahr
Copy link
Owner

miurahr commented Jul 1, 2024

Patching qconfig.pri has been implemented in #210 in 2021.

@miurahr miurahr added triage and removed good first issue Good for newcomers labels Jul 1, 2024
@IMAN4K
Copy link
Author

IMAN4K commented Jul 1, 2024

Your qconfig.pri is different from mine, it needs to be investigated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed need more information triage
Projects
None yet
Development

No branches or pull requests

2 participants