Make track color visible in track properties dialog

[mixxxbot]

Reported by: daschuer
Date: 2021-02-19T07:34:03Z
Status: Confirmed
Importance: Undecided
Launchpad Issue: lp1916119
Tags: easy

---

The track color is currently not visible nor editable in the track properties dialog.
That would be a nice addition.

[dassudip2001]

can you send any screenshots of which position changes

[daschuer]

Do you have interest to adopt this bug?
I think it is up to you to decide the position in the track dialog. Maybe you can send a mock up with an Gimp edited Screenshot to discuss your ideas.
The related code can be found here
https://github.com/mixxxdj/mixxx/blob/main/src/library/dlgtrackinfo.ui

[tech-bash]

I will try to achieve it, first I will have a new column with "Text Color" as field and then assign to the color value that track is holding.

[tech-bash]

Once this is achieved I will open a PR, and after that for editing color of track we can have a button in front of the Text Color label which will redirect to color palette as in the track dialog for setting the color which can maybe considered as a new feature for track properties dialog!

[daschuer]

Thank you for adopting this.
You mean Track Color? As a first step you may show here a screenshot form QT-Designer with the new row in the track dialog.

[tech-bash]

Alright.

[tech-bash]

Something like this maybe!

[daschuer]

Can the color become a Combobox? Like the loop default color in the preferences?

[tech-bash]

Yes it can, but this feature will take time for me to implement then!

[ronso0]

Can the color become a Combobox? Like the loop default color in the preferences?

Exactly.
@tech-bash You don't need to reinvent the wheel, I'm pretty sure you can adopt bits from the Color preferences.

[tech-bash]

Ok.

[tech-bash]

We just need the values as described in loop default color? And don't have to worry about the color pallete(s)!

If that's the case then I am on it you can assign it to me and would try to open the PR by tomorrow or day after!

[ronso0]

This is about track colors so you need the current track color palette.
Pointing you to the Color preferences was wrong, sorry. Instead, you should check src/widget/wcolorpickeraction.cpp and how it's used by the track menu.

For consistency we should use the same color grid in Track Properties (not a combobox as initially proposed).

[tech-bash]

Ahh, dlgprefcolors.cpp was a bit confusing though I suppose!

[tech-bash]

main...tech-bash:mixxx:feat/trackColor, here are my recent changes for track color, my question is how can link QPushButton's value dynamically with the class btnTrackColor that I created for changing track color? In that class only I defined all the changes needed, what I am trying to do is - display the current Color on QPushButton and update it when the color geta updated!

[daschuer]

Please issue a Pull Request prefixed with [WIP]
Than it is easy to discuss along the code.

[tech-bash]

Ok