updating cue point seeks to old cue point

[mixxxbot]

Reported by: ywwg
Date: 2021-10-08T02:43:14Z
Status: Fix Committed
Importance: Medium
Launchpad Issue: lp1946415

---

on main, if I try to set a new cue point, the operation works, but the track seeks to where the cue point used to be

[mixxxbot]

Commented by: ninomp
Date: 2021-10-08T17:41:07Z

---

I noticed this too, but I think this only happens when trying to place cue point in preroll.

[mixxxbot]

Commented by: ywwg
Date: 2021-10-09T20:04:24Z

---

This happens to me 100% of the time, not just preroll

[mixxxbot]

Commented by: ywwg
Date: 2021-10-09T20:11:37Z

---

Ah, it's because of 036754d, which did this:

-    double cuePoint = m_pCuePoint->get();
+    const auto mainCuePosition =
+            mixxx::audio::FramePos::fromEngineSamplePosMaybeInvalid(
+                    m_pCuePoint->get());

so when the cuepoint is updated, we seek to the old position.

[mixxxbot]

Commented by: ywwg
Date: 2021-10-09T20:17:35Z

---

I'm making a small PR, should be uncontroversial?

[mixxxbot]

Commented by: ywwg
Date: 2021-10-09T20:23:48Z

---

#4370

[mixxxbot]

Commented by: Holzhaus
Date: 2021-10-09T20:40:34Z

---

@ywwg: I don't understand how the bug was caused by the change diff you posted. The lines are identical semantically, it's just that the variable type is different.

[mixxxbot]

Commented by: ywwg
Date: 2021-10-10T21:49:14Z

---

it's not caused by just those lines -- by assigning the cue position to a variable, when we update the cue position the variable still has the old value. See the PR for the complete fix.

[mixxxbot]

Issue closed with status Fix Committed.