Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Components JS docs up-to-date #10618

Closed
mixxxbot opened this issue Aug 23, 2022 · 6 comments
Closed

Get Components JS docs up-to-date #10618

mixxxbot opened this issue Aug 23, 2022 · 6 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: Swiftb0y
Date: 2021-12-18T20:32:18Z
Status: New
Importance: Undecided
Launchpad Issue: lp1955313


I was told to create a bug for this and attach it to the 2.4 so we don't forget about it. #4550 (comment)

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
@ywwg
Copy link
Member

ywwg commented Jan 6, 2024

To be specific, the mixxx components js has changed since 2.3 so we need to update the documentation on the wiki: https://github.com/mixxxdj/mixxx/wiki/Components-JS.

@ronso0
Copy link
Member

ronso0 commented Jan 6, 2024

Commits to midi-components-0.0.js since 2.3 was released 2021-06-28:
306bbe4
80f5bc6
efabcf6
b8da147
d232bbb
8d60978
2649ef6
311eb1a
acfcdce
4ec46c6
eb3ab38

Changelog of the wiki page:
https://github.com/mixxxdj/mixxx/wiki/Components-JS/_history

@daschuer
Copy link
Member

daschuer commented Feb 5, 2024

@Swiftb0y how is the situation here? Can we remove the milestone?

@ronso0
Copy link
Member

ronso0 commented Feb 5, 2024

As a bandaid we can add a disclaimer to the wiki page that it needs to be updated.

@Swiftb0y
Copy link
Member

Swiftb0y commented Feb 5, 2024

working on it right now. shouldn't be much that needs changing currently.

@Swiftb0y
Copy link
Member

Swiftb0y commented Feb 5, 2024

done. was just Pot#softTakeover. Thank you @ronso0 for the list of relevant commits, that made it really easy.

@Swiftb0y Swiftb0y closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants