Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow point-and-click MIDI learning of Hotcue buttons #10842

Closed
ronso0 opened this issue Aug 30, 2022 · 1 comment · Fixed by #12252
Closed

allow point-and-click MIDI learning of Hotcue buttons #10842

ronso0 opened this issue Aug 30, 2022 · 1 comment · Fixed by #12252

Comments

@ronso0
Copy link
Member

ronso0 commented Aug 30, 2022

Hotcue buttons can not be mapped with the MIDI Learning Wizard with point-and-click, because the widget connections of WHotcueButton are created by the class itself, not by LegacySkinParser::setupConnections, so the controls are not available in the ControllerLearningEventFilter (actually only activate and enabled are controls, remove and the context menu are handled in mousePressEvent)

Note: this is not a big deal since the controls are available in the controls menu, though to accelerate mapping point-and-click would be nice.

@ronso0
Copy link
Member Author

ronso0 commented Aug 30, 2022

This quick patch adds _activate to the learning filter
MIDI-learning-allow-learning-HotCue-button-with-poin.patch.txt broken
Pick it up if you like, I don't have any motivation to get this to work for _clear. Maybe that can be accopmplished with a helper in WHotcueButton, idk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant