Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numark DJ2GO2 Touch clearing hot cues #11408

Closed
sven-simulacrum opened this issue Mar 26, 2023 · 6 comments
Closed

Numark DJ2GO2 Touch clearing hot cues #11408

sven-simulacrum opened this issue Mar 26, 2023 · 6 comments
Labels

Comments

@sven-simulacrum
Copy link

Bug Description

I know this issue was addressed in "Add hotcue clearing support #10849", however as far as I can tell this change was not implemented to the latest build of Mixxx 2.3.4? I’ve tried to change the Numark_DJ2GO2_Touch_scripts.js file manually but receive an error on line 103: " for (let i = 1; i <= 4; i++) { " returns an error ("expected ;"). Any advice? Apologies I’m no coder!

Version

2.3.4

OS

macOS Mojave 10.14.6

@Swiftb0y
Copy link
Member

So when I double checked the script, hotcue clearing support should be there. I think mixxx uses an outdated version of your mapping. In what exact folder is the mapping file located you are looking at?

@doteya
Copy link
Contributor

doteya commented Mar 27, 2023

@sven-simulacrum
Do you test clear-hotcue function with mixxx 2.3.4?
It works. I had implemented #10841. Nothing is needed from #10849.

If you think that the code like "for (let i = 1; i <= 4; i++) {" is not implemented, it's not needed.
Because "let" keyword is supported from ECMA-262 6th edition, but QtScript supports only ECMA-262 3rd edtion. the #10849 code using "let" is bugged code for mixxx 2.3.x.
We must implement with "var".

@sven-simulacrum
Copy link
Author

Hello
Yes I’m using mixxx 2.3.4. I just downloaded again and re-installed it. I’m trying to clear a cue when it is in the first "Hot Cue" mode. I just downloaded again and re-installed it. I’ve opened the app package: Contents –> Resources –> controllers –> Numark_DJ2GO2_Touch_scripts.js

@doteya
Copy link
Contributor

doteya commented Mar 28, 2023

Push "PAD MODE" key to select "CUES" mode.
When push one of pad, put cue position if the cue is cleared or jump to cue position if the cue is filled in "CUES" mode.
If you want to clear cue, push pad with holding "PAD MODE" in "CUES" mode.
"PAD MODE" key is used like "shift" key.

If the mode is not "CUES" mode, it makes no effect with holding "PAD MODE".

@sven-simulacrum
Copy link
Author

Aha...OK I worked out the issue.

Even after installing a new version of Mixxx 2.3.4 the User Mapping Folder was still pointing to a midi.xml file in my OS User Library.
Preferences –> Controllers –> Open User Mapping Folder

Now I’ve selected "DJ2GO2 Touch" under Preferences –> Controllers. Then Load Mapping –> Numark DJ2GO2 Touch. Mapping Files are all "built in".

All seems to be working now. Many thanks!!

@Swiftb0y
Copy link
Member

Great, thank you @doteya for helping with troubleshooting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants