-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preferences
on macOS are now called Settings
#11642
Comments
should be labeled with |
So someone translated Preferences > Settings on Transifex which caused the issue reported here #11670 (comment) ? |
I don't think the issue is translation related. The problem comes from QActions &Preferences and &Settings referring to the same internally in Qt. |
In fact , this is what happens: From Qt docs on QAction menuRole: "This indicates what role the action serves in the application menu on macOS. By default all actions have the TextHeuristicRole, which means that the action is added based on its text (see QMenuBar for more information)." So, these text heuristics assign the role PreferenceRole to both. |
Fixed now by changing the menu role in #11679 |
Thanks for clarifying @m0dB So is this issue solved by TextHeuristicRole and |
Tested in 2.5-alpha-53-g5f22560dce (main) There is a remaining problem for the Settings window itself which currently still shows
|
How could we handle different terms in the manual? |
The Mixxx manual refers to "Preferences", so we have an incositency (on macOS) either way:
changing the window title per pane would be nice, but is indepent because it doesn't solve the inconsstency described above. |
Have to admit, I had not thought about documentation. Probably fair to stick with |
Maybe just add a disclaimer for macOS users to the mental translation themselves? |
By setting the menuRole to QAction::PreferencesRole, the menu item text is set to either "Settings" or "Preferences", depending on the version of macOS. This is independent of the title that is passed to the QAction constructor (which is completely ignored). I am on Monterey and here it's still Preferences. Now, for the Dialog title: According to Apple's Human Interface Guidelines, the title of the dialog should actually be neither Preferences nor Settings! See https://developer.apple.com/design/human-interface-guidelines/patterns/settings/ which reads:
As we do have multiple panes (or tabs if you will), we would set the title to the selected tab (e.g. Sound hardware, Library, etc). That way we kill two birds with one stone: we don't have to worry about a inconsistency between the menu item and the dialog title, and we integrate more correctly in the host OS. If we don't want to go that route, I have some obj-c code that programmatically determines the title of the actual application menu's Settings / Preferences menu item . We could use this to set the title of the Settings / Preferences dialog so it matches. And finally we could forget about the whole ordeal, and force the use of Preferences instead of Settings independent of the version of macOS. This is explained here: https://lapcatsoftware.com/articles/Preferences.html My personal preference would be setting the title to the selected tab, for the reasons above but also because it is trivial, and only requires Qt/c++ code. As for the manual, I think that a simple disclaimer would do the trick. Something along the lines of: "On macOS Ventura and later, the "Preferences..." application menu item has been changed to "Settings...". Note that this documentation still refers to Preferences." (But frankly, I'm sure that all macOS Ventura users are aware of this change) |
PR created: #11696 |
Feature Description
Adapt new Apple terminology. In macOS 13 Ventura they renamed
System Preferences
toSystem Settings
and followed up on that change with all apps renamingPreferences
toSettings
.Mixxx should follow that change as well for macOS and rename menu bar > Mixxx > Preferences… to Settings…
The text was updated successfully, but these errors were encountered: