Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double Click on the track title label in decks crashes Mixxx #11802

Closed
stefan-franz opened this issue Aug 9, 2023 · 5 comments
Closed

Double Click on the track title label in decks crashes Mixxx #11802

stefan-franz opened this issue Aug 9, 2023 · 5 comments

Comments

@stefan-franz
Copy link

stefan-franz commented Aug 9, 2023

Bug Description

Double click on the title should bring the properties window - the window appears, but stays black and after 2 seconds Mixxx crashes. Hope fast fix because i use Mixxx on a wedding party on friday.

Version

2.4 beta 79

OS

Linux Mint 21.2 Cinnamon

@ronso0
Copy link
Member

ronso0 commented Aug 9, 2023

If you can reproduce it reliably please create a backtrace https://github.com/mixxxdj/mixxx/wiki/Creating%20Backtraces

@ronso0
Copy link
Member

ronso0 commented Aug 9, 2023

Uff, can confirm. Handling the result of QHash::find in #11764 is wrong, it'll crash with nonexistant property string.
I'm about to fix it.
This reveals another issue: at least LateNight uses titleInfo instead of title for track labels. Not sure if it was always like that, or if I changed that in the LateNight redesign, and if so why.

@stefan-franz Unfortunately there's no consecutive list of builds in http://ppa.launchpad.net/mixxx/mixxxbetas/ubuntu/pool/main/m/mixxx/, so the last version without this PR is mixxx_2.4~beta~60

@ronso0 ronso0 added this to the 2.4.0 milestone Aug 9, 2023
@ronso0 ronso0 changed the title Double Click on the loaded title of track on Deck 1 or 2 crashes Mixxx Double Click on the track title label in decks crashes Mixxx Aug 9, 2023
@ronso0
Copy link
Member

ronso0 commented Aug 9, 2023

at least LateNight uses titleInfo instead of title for track labels. Not sure if it was always like that, or if I changed that in the LateNight redesign, and if so why.

okay, all skins use this in decks and samplers, so I'll simply forward titleInfo to the track title field.

@ronso0
Copy link
Member

ronso0 commented Aug 10, 2023

fixed by #11804

@stefan-franz
Copy link
Author

Linux Mint doesn't find an update to download. Not fixed at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants