-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixxx 2.4-beta crash on Windows 10 with No GL #11929
Comments
Backtrace:
|
--safe-mode fixes the issue So I guess there QOpenGLWindow is used even though we know, it is not available. |
Debug [Main] Set root GL Context widget valid: WInitialGLWidget(0x19479a47900) false |
|
Looks like this is expected because the widget is created unconditionally. What is the Qt6 compatible counterpart to Lines 231 to 235 in 8a16387
this might fix it... diff --git a/src/mixxxmainwindow.cpp b/src/mixxxmainwindow.cpp
index df259b359d..7c84e42875 100644
--- a/src/mixxxmainwindow.cpp
+++ b/src/mixxxmainwindow.cpp
@@ -8,6 +8,7 @@
#ifdef MIXXX_USE_QOPENGL
#include "widget/tooltipqopengl.h"
#include "widget/winitialglwidget.h"
+#include <QOpenGLContext>
#else
#include <QGLFormat>
#endif
@@ -149,7 +150,7 @@ MixxxMainWindow::MixxxMainWindow(std::shared_ptr<mixxx::CoreServices> pCoreServi
#ifdef MIXXX_USE_QOPENGL
void MixxxMainWindow::initializeQOpenGL() {
- if (!CmdlineArgs::Instance().getSafeMode()) {
+ if (!CmdlineArgs::Instance().getSafeMode() && QOpenGLContext::isValid()) {
// This widget and its QOpenGLWindow will be used to query QOpenGL
// information (version, driver, etc) in WaveformWidgetFactory.
// The "SharedGLContext" terminology here doesn't really apply, |
Not sure if that's the correct way. I will prepare a PR with a proposed fix. |
I have already one in progress. Testing works. Only need some final look. |
Here it is: #11963 |
QOpenGLContext::isValid() suffers the chicken egg issue. The returned value is currently only significant with a widget. But it crashes before we can check. In the PR I have revived the QGLFormat::hasOpenGL() for the QT5 case (Mixxx 2.4 is Qt 5) and checked QOpenGLContext::create() of a dummy context in case of Qt 6. This fixes the issue for 2.4 and the main branch. |
Bug Description
Tested on Virtual Box 7.
EXCEPTION_ACCESS_VIOATION
At the beginning ther is a popup about missing OpenGL
Version
2.4-beta
OS
Windows 10
The text was updated successfully, but these errors were encountered: