Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the spinnies the Vinylcontrol signal is not properly masked #12202

Closed
JoergAtGithub opened this issue Oct 21, 2023 · 2 comments
Closed

In the spinnies the Vinylcontrol signal is not properly masked #12202

JoergAtGithub opened this issue Oct 21, 2023 · 2 comments

Comments

@JoergAtGithub
Copy link
Member

In the spinnies the Vinylcontrol signal is also visible outside of the round area:

Aufzeichnung.2023-10-20.232434.mp4

Maybe it's just me, but I expected this to be masked as the Cover-Art.

Originally posted by @JoergAtGithub in #12100 (comment)

@ronso0
Copy link
Member

ronso0 commented Oct 21, 2023

If it was masked the signal would be clipped, i.e. information be hidden. Is it really desirable to constrain the signal just for keeping the corners clean?
IIUC only clipping is applicable (changing the stack order), not scaling if the graph (when? always? set scale factor based on the assumption that the mask is circular?)l

@m0dB
Copy link
Contributor

m0dB commented Oct 22, 2023

I agree with @ronso0 . The information is part of the vinyl quality image. The fact that we draw it together with the spinny is coincidental. I propose to close this as not a bug.

@ronso0 ronso0 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants