Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search related Tracks: allow to combine filters #12211

Open
ronso0 opened this issue Oct 23, 2023 · 3 comments · Fixed by #12213
Open

Search related Tracks: allow to combine filters #12211

ronso0 opened this issue Oct 23, 2023 · 3 comments · Fixed by #12213

Comments

@ronso0
Copy link
Member

ronso0 commented Oct 23, 2023

Just an idea while reading #5655 and other 'find similar tracks' feature requests.

The 'Search related Tracks' menu could be 'combo items':
checkboxes with the existing actions

  • Clicking the action (text) would instantly trigger a search with the respective query
  • Checking one or more items would enable a 'Search' button at the bottom of the menu
  • Clicking 'Search' would combine the queries and trigger a search

This would, for example, simplify searching for compatible keys and compatible BPM, without having to combine (copy/paste) queries manually.
The current workflow (clicking one specific action) would not be affected.

Implementation can (hoepfully) be adopted from Crates menu (QWidgetAtcion with QCheckBox).

@mxmilkiib
Copy link
Contributor

A variation of that;

A MIDI bind, which, when triggered, makes the library view change to show search results from within the library/current crate that have a BPM and key that are appropriate to mix into from the currently playing track.

@ronso0
Copy link
Member Author

ronso0 commented Nov 10, 2023

Sure, sounds helpful.
It's only losely related to the menu and involves new controls, could you please open a new issue?

@Swiftb0y
Copy link
Member

fyi wireshark has something like this where you can right click on a field and then say "Prepare/Apply as filter". I personally find it a bit clunky, though I'm not sure how to implement much better.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants