Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Track colour palette cycling controls for decks #12905

Closed
mxmilkiib opened this issue Mar 2, 2024 · 2 comments · Fixed by #13066
Closed

add Track colour palette cycling controls for decks #12905

mxmilkiib opened this issue Mar 2, 2024 · 2 comments · Fixed by #13066

Comments

@mxmilkiib
Copy link
Contributor

mxmilkiib commented Mar 2, 2024

Feature Description

There is track_color but that's to set a specific rgb colour. (#2541)

It would be handy to be able to use MIDI to cycle through the limited palette of track colours that are available via the Library UI.

Mapped to a rotary encoder.

@mxmilkiib mxmilkiib changed the title Track colour cycling, MIDI trigger? Track colour palette cycling, via MIDI? Mar 2, 2024
@ronso0
Copy link
Member

ronso0 commented Mar 3, 2024

So basically a per-deck equivalent for [Library],track_color_prev](https://manual.mixxx.org/2.4/en/chapters/appendix/mixxx_controls.html#control-[Library]-track_color_prev)

Here's the library implementation

m_pTrackColorPrev = std::make_unique<ControlPushButton>(ConfigKey("[Library]", "track_color_prev"));

and here the existing deck control

m_pTrackColor = std::make_unique<ControlObject>(

Tagging this 'easy', it's only about porting the _prev/_next controls to basetrackplayer.

@ronso0 ronso0 changed the title Track colour palette cycling, via MIDI? add Track colour palette cycling controls for decks Mar 3, 2024
@ronso0 ronso0 added the easy label Mar 3, 2024
@mxmilkiib
Copy link
Contributor Author

Cheers! I'm going to focus on looking at the fractional BPM scaling control the now.

@ronso0 ronso0 linked a pull request Apr 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants