Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock BPM of full library doesn't work #13142

Open
RafaelFrance opened this issue Apr 20, 2024 · 11 comments
Open

Unlock BPM of full library doesn't work #13142

RafaelFrance opened this issue Apr 20, 2024 · 11 comments
Labels

Comments

@RafaelFrance
Copy link
Contributor

RafaelFrance commented Apr 20, 2024

Bug Description

Start situation : some tracks of the library have BPM locked (not all).

Select the full library with Ctrl+A.
Unlocking : Adjust BPM/Unlock BPM
A progress window opens, but closed at around 15-30%.
Some tracks stay locked.

The progress windows of unlock doesn't show the number of tracks (has I can see when I lock a small number of track). It shows " % n tracks"

Unlock BPM works when selecting individual tracks or an area of several tracks.

Version

2.4.0

OS

Ubuntu 22.04

@ronso0
Copy link
Member

ronso0 commented Apr 20, 2024

So this is about unlocking via the track menu?

@ronso0
Copy link
Member

ronso0 commented Apr 20, 2024

In which view? Tracks?

@RafaelFrance
Copy link
Contributor Author

RafaelFrance commented Apr 20, 2024

Yes, in Tracks list (view).

Tango skin.

@ronso0
Copy link
Member

ronso0 commented Apr 22, 2024

If you can reproduce this, please attach the log. That may reveal the reason the batch op was aborted.

A progress window opens, but closed at around 15-30%.
Some tracks stay locked.

Are "some tracks" the remainders (~70 %)?

@ronso0
Copy link
Member

ronso0 commented Apr 22, 2024

I could somehow reproduce this:

  • test library with 16k tracks, some have BPM, most don't
  • go to Tracks, mark all tracks
  • track menu -> BPM -> Lock BPM
  • (progress dialog okay, takes some time)
  • = all tracks locked, regardless of BPM

The reverse however fails, or rather there is an issue with the tracks view:

  • mark all tracks, BPM -> Unlock BPM
  • (batch task seems to finish successfully)
  • issue with all many tracks with no BPM:
    • all rows show the Lock icon, however when selecting the library row the icon is Unlocked
      (only true for the initially selected row, i.e. for a selection range all other selected rows are still shown as Locked)
    • track menu -> BPM offers only "Lock BPM"
  • issue persists across restarts

Then

  • load an affected track to a deck OR menu -> Analyze -> Re-analyze
  • as soon as BPM track analysis starts (indicates BPM are not locked) the lock icon is now correct (= unlocked)

I'll take a look.

@RafaelFrance
Copy link
Contributor Author

Attached video, log and cfg files.
mixxx cfg file.txt
mixxx.log
Capture vidéo du 24-04-2024 13:06:43.webm

My Library is around 7600 tracks.
Only 109 tracks on a Playlist have (all 109 tracks) BPM locked.
Video shows when I tried (and failed) to unblock all tracks of the Library.

Note : I use BPM lock to visual organization of my tracks, lick colors. BPM are mainly imported from Metadata of files.

@ronso0
Copy link
Member

ronso0 commented Apr 24, 2024

Could you please verify:
if all tracks have been analyzed (do batch analysis via the Analyze feature (sidebar)) lock/unlock works for all tracks?

@RafaelFrance
Copy link
Contributor Author

RafaelFrance commented Apr 24, 2024

Tracks as they are today (BPM are mainly imported from Metadata of files)

  • Analyse of tracks (7636) (batch analysis via the Analyze feature (sidebar))
  • lock all Tracks (7636). Problem : the progress windows stop before the end of process. A lot of Tracks are not locked.
  • I found two Track where I can not unclock BPM manualy. I Hide these two Tracks.
  • Lock all tracks (7634). Problem : the progress windows stop before the end of process. A lot of Tracks are not locked.
  • Unlock all tracks (7634). Seems to work (because few tracks locked ?).
  • All Tracks selected (7634) / Reset / BPM and Beatgrid. Problem : the progress windows stop before the end of process. A lot of Tracks are not reset.

Not sure but progress windows seems to stop always between 20% and 30%

@ronso0
Copy link
Member

ronso0 commented May 28, 2024

I found two Track where I can not unclock BPM manualy. I Hide these two Tracks.

(I suggest you make a backup of your library so you can retest with thi state later on)
Please run Mixxx from the command line, note the logged lines when you attempt to lock/unlock these two tracks and post them here.
https://manual.mixxx.org/2.4/en/chapters/appendix/commandline_dev_tools.html

@RafaelFrance
Copy link
Contributor Author

RafaelFrance commented May 28, 2024

In a crate wiht the 2 tracks (with problem)
Initial : the tracks are locked.

Unlock of all

  • doesn't work.
  • no logged line.

Unlock manualy (with mouse click on icon)

  • doesn't work.
  • no logged line.

Load track 1 on Desk
warning [AnalyzerThread 0 #1] SoundSourceMp3 - Reading MP3 data with different sample rate 48000 Hz <> 44100 Hz - aborting
warning [AnalyzerThread 0 #1] AudioSource - Failed to read sample frames: expected = [221184 -> 225280) , actual = [221184 -> 222336)

Load the track 2 on Desk
warning [Main] Track duration has changed since last analysis 1904 != 1921
warning [CachingReaderWorker 1] First sound has been moved! The beatgrid and other annotations are no longer valid "file:///Datas/Musiques/Silence3s.mp3"

Note: I see that these two track are "special".

  • track 1 : duration 4:16, but a waveform of only 5 seconds. After it is a straight line on the waveform.
  • track 2 : duration 3 seconds.

@ronso0
Copy link
Member

ronso0 commented Jun 2, 2024

So the root cause is broken audio files?

Can you lock/unlock after resetting BPM, beatgrid and waveform for those two tracks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants