-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce number of waveform options #6428
Comments
Commented by: esbrandt Agree that the waveform options is rather complex. Some thoughts. Visual gain: My vote is for leaving it in. It is probably not that useful for EDM or other popular music, but for some less bassy older music ( e.g. 70 Zoom factor: Current waveform zoom range is 1-6 where 1 is default and this is too close (Zoom steps are geeky too). We have less than 1 second of audio visible per default now in the standard skin. Better use something like 100%-10% in steps of 10 where 50% is default so we can use 3 not yet added zoom buttons (In/Out/Reset to default) per deck in the GUI. Imo the waveform options should move to a separate tab in the Preferences just like crossfader/EQ. Would also make the preferences dialog shrink a bit from it`s current height. |
Commented by: rryan I agree waveform stuff should probably graduate to its own section now. I think GL status and actual FPS should stay so that when we get bug I talked w/ Owen a bit about this but the new waveforms are going to cause I think visual-gain might be useful but I think it'd be better as a slider. I agree w/ jus's comments about zooming. I wasn't sure if separate zoom On Fri, May 11, 2012 at 2:22 PM, jus wrote:
|
Commented by: esbrandt For reference, the separate bug for moving the waveform to its own section at lp:1014258 |
Commented by: Pegasus-RPG Don't forget my work in bug #896880 incase its helpful. |
Commented by: esbrandt Alot has changed in the waveforms preferences over the time. The new preferences tab is much more structured, and should help the users to get by. But some of the issues of the initial post remain ( Visual gain, zooming, advanced tab...) |
Offer a selection with two options (drop down):
Based on the selected option only show the available variants. Those variants should be distinct by their features and not mention any technical details of the implementation. |
Following suggestion from Uwe here and in #11615, could we reduce the
And a checkbox on the right, something like |
I would leave out the "use acceleration" checkbox. If acceleration is available, use it. If no hardware accel is desired, this would also apply to the spinnies, so a dedicated checkbox for waveforms does not make sense. I guess the user could just enable safe mode? |
There is an issue with accelerated and non-accelerated waveform actually looking different. I have made a version with the checkbox for now, but we could hide it if not in safe mode easily once the looking issue is fixed. |
I am going to close this one in favor of #13226 because the mixbot stuff is a little spammy and most of this discussion is obsolete. |
Reported by: ywwg
Date: 2012-05-11T15:22:52Z
Status: Confirmed
Importance: Low
Launchpad Issue: lp998096
Tags: usability, waveform
I love the new waveforms, but the preferences window for them is ugly and over-engineered. The number of bugs for various individual waveform implementations is also proliferating so reducing the options here will also reduce some of those issues.
I understand that many of these options allow users to fine-tune the waveform for their individual machine's capability, but I think we need to better balance the interests of debugging and the interest in not scaring our users. Most DJs don't know what OpenGL is, or why they'd want to use shaders or not... So the basic waveform settings have to be easily-grasped. Further complexity, for debugging, should be hidden or reduced.
In my ideal world there would be a single waveform dropdown, and it would contain:
(where "hardware accelerated" means opengl)
Simple would be our simplest waveform running at a low fps, like 15fps.
Complex would be a pure-QT filtered waveform running at 30fps. This is our "compatibility mode" for fast systems that have graphics card issues with GL.
Complex (hardware accelerated) would our GL implementation, also running at 30.
As for the options, some of them are useful for debugging and development, but some seem unnecessary to me.
Debugging/Advanced elements:
Having the actual fps is ok for development but unnecessary for most users. If it's running slow they will drop down to Simple. I've been told some people like to boost this to 60 for ultra-smoothness.
99% of the time I don't care what my opengl status is.
Superfluous elements:
I think "visual gain" is unnecessary, and might have mostly been a workaround for some bugs in the analyzing code. I suggest we drop it completely. Perhaps we could replace it with an option to either fill the height with the waveform, or leave the height as a function of the gain.
We should just pick a default zoom. If the user changes the zoom, save that setting as the new default.
I'm not sure why waveform zooms wouldn't be synchronized.
RJ suggested an "advanced" tab... maybe we could have something like:
[ Waveform Dropdown ]
[+] Advanced
So the Advanced options are in a twirl-down section, not a tab, but they are hidden by default.
The text was updated successfully, but these errors were encountered: