Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playlist],SelectPlaylist doesn't work anymore #8766

Closed
mixxxbot opened this issue Aug 23, 2022 · 12 comments
Closed

[Playlist],SelectPlaylist doesn't work anymore #8766

mixxxbot opened this issue Aug 23, 2022 · 12 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: ronso0
Date: 2017-01-19T13:18:51Z
Status: Fix Released
Importance: High
Launchpad Issue: lp1657743


When a playlist, crate or other view has focus, the following controls for side pane don't work, unless library side pane is focused manually:

[Playlist],SelectNextPlaylist
[Playlist],SelectPrevPlaylist
[Playlist],SelectPlaylist
Probably other [Playlist] controls are affected as well.

On the other hand, when side pane has focus Track controls still work in track table:
[Playlist],SelectNextTrack
[Playlist],SelectPrevTrack
[Playlist],SelectTrackKnob

It was working until I recently switched from r6071 to r6109.

@mixxxbot mixxxbot added the bug label Aug 23, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-01-19T18:52:29Z


Update your mapping for the new [Library] COs:
http://mixxx.org/wiki/doku.php/mixxxcontrols#library

introduced by #953

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2017-01-19T19:16:29Z


This means we broke backwards compatibility, so it's still a bug though.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-01-20T11:38:27Z


Thank, that's a ton of new controls! nice.

This also means controller presets can be updated/reworked..

Is there a changelog somewhere? It's hard to track changed controls, new sin features, etc. so it would be very helpful to have one.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-01-20T22:00:37Z


You can look at the changelog of the mixxxcontrols wiki page:
http://mixxx.org/wiki/doku.php/mixxxcontrols?do=revisions

The changes should be summarized on the new upgrading mappings page:
http://mixxx.org/wiki/doku.php/updating_controller_mappings

@mixxxbot
Copy link
Collaborator Author

Commented by: timrae
Date: 2017-01-20T23:42:31Z


Thanks for the report, it looks like it was only those controls that were affected. PR submitted:
#1137

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-01-23T16:06:26Z


@timrae Thanks for fixing. Though I already switched to the new COs in the meantime..
@be.ing Thanks for pointing me there. Going through the revisions would not be very obvious/easy for users switching to 2.1 alpha while controller presets are not updated, yet. http://mixxx.org/wiki/doku.php/updating_controller_mappings is handy altough the COs in question are not listed yet.

@mixxxbot
Copy link
Collaborator Author

Commented by: timrae
Date: 2017-01-23T22:49:47Z


@ronso0

Currently the best place to look for changes is the list of deprecated
controls:
http://www.mixxx.org/wiki/doku.php/mixxxcontrols#deprecated_controls

On Tue, Jan 24, 2017 at 1:06 AM, ronso0 wrote:

@timrae Thanks for fixing. Though I already switched to the new COs in the
meantime..
@be.ing Thanks for pointing me there. Going through the revisions would
not be very obvious/easy for users switching to 2.1 alpha while controller
presets are not updated, yet. http://mixxx.org/wiki/doku.
php/updating_controller_mappings is handy altough the COs in question are
not listed yet.

--
You received this bug notification because you are a bug assignee.
https://bugs.launchpad.net/bugs/1657743

Title:
[Playlist],SelectPlaylist doesn't work anymore

Status in Mixxx:
Fix Committed

Bug description:
When a playlist, crate or other view has focus, the following controls
for side pane don't work, unless library side pane is focused
manually:

[Playlist],SelectNextPlaylist
[Playlist],SelectPrevPlaylist
[Playlist],SelectPlaylist
Probably other [Playlist] controls are affected as well.

On the other hand, when side pane has focus Track controls still work in
track table:
[Playlist],SelectNextTrack
[Playlist],SelectPrevTrack
[Playlist],SelectTrackKnob

It was working until I recently switched from r6071 to r6109.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1657743/+subscriptions

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-01-24T15:03:45Z


Thanks again.

I really hope I'm not annoying here, when I propose another feature:
To extend the use of the new as well as the old COs, it would be very cool to have a 'feedback' CO like TreeViewHasFocus, TrackTableHasFocus, TreeItemIsCollapsed (or whatever is coming with the Library redesign in progress).

I currently use the new COs (especially fast scrolling is handy for long playlists/history), but I also sometimes use the mouse for overview waveform or whatever. After doing so, neither Tree nor Tracks have focus. A while after that -hands on the controller- I want to select and load a track from Tracks table, but would have to put focus back there manually.
I think, with the proposed COs it would be easy to create script solutions for various scenarios/flavours and for many different controller layouts.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2017-01-24T16:42:34Z


Since this bug is fixed, please copy your request to a new bug.
Than we can track it separate.

For me it sounds more like a bug, and that should not bother the controller.
Does it also happen in the new library redesign branch?

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-01-31T15:46:08Z


Sorry for the delay.

I will test again as soon as the redesign is merged.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-03-15T17:32:34Z


I reported that focus loss in https://bugs.launchpad.net/mixxx/+bug/1673196

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.1.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant