Pressing Hotcues buttons randomly deactivate loop

[mixxxbot]

Reported by: twontu
Date: 2018-06-22T15:47:58Z
Status: Fix Released
Importance: High
Launchpad Issue: lp1778246
Tags: cue, looping

---

MIXXX 2.1.0 / WindowsOS

I've noticed that if
1)I set an hotcue and activate a loop (loop start = hotcue),
2) click play to start playing,
3) and then click the hotcue button to restart the loop before it ends, it randomly disables the loop.

This happens only if sync and quantize are both activated.
It happens also if you map
cue_gotoandplay
to a controller

Tested with and without controllers.

It happens randomly so you have to press/click the hotcue button several times to reproduce the problem.

Is there anything I'm doing wrong? Thanks for your support

[mixxxbot]

Commented by: daschuer
Date: 2019-07-06T22:11:24Z

---

I think #2190 is fixing this one as well.

[mixxxbot]

Commented by: goddisignz
Date: 2019-07-15T06:28:14Z

---

Would also be my assumption. Do I then have to backport it to version 2.1 or what is the policy in Mixxx?

[mixxxbot]

Commented by: daschuer
Date: 2019-07-15T08:13:18Z

---

Yes, in this case we may fix the bug in the 2.1 branch only. After merge the related PR, we merge the 2.1 branch into master. In the common case, the fix should not be included in the PR against master to avoid conflicts. Here, we may consider if it is worth the work.

[mixxxbot]

Commented by: goddisignz
Date: 2019-07-16T20:30:06Z

---

Ok, then I will basically move all the changes to the 2.1 branch and create a new PR.
I would then close #2190 and move the "is a seek queued"-stuff to a new PR as well.
This should avoid conflicts, right?

[mixxxbot]

Commented by: daschuer
Date: 2019-07-16T20:58:04Z

---

Sounds good. Thank you!

[mixxxbot]

Commented by: goddisignz
Date: 2019-07-18T20:11:25Z

---

New PR here: #2209

[mixxxbot]

Issue closed with status Fix Released.