Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store selected table item index when switching library features #9547

Closed
mixxxbot opened this issue Aug 23, 2022 · 10 comments
Closed

store selected table item index when switching library features #9547

mixxxbot opened this issue Aug 23, 2022 · 10 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: ronso0
Date: 2018-12-14T06:20:37Z
Status: Fix Committed
Importance: High
Launchpad Issue: lp1808472
Tags: library, usability


scenario:

  • listen to tracks from Tracks view
  • find a track that inspires you to start a new playlist
  • right-click any other library feature like Playlists or Crates
     (for example to create or rename a playlist/crate)*
    = tracks table switches to respective library feature
    (damn! lp:1810810)
  • go back to Tracks
    = table shows correcct scroll position
  • use [Library],ScrollVertical,+-1
    = scroll position jumps to top of the list

master (2.3) 2018-12-14

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2018-12-16T23:04:13Z


I cannot confirm this with the current master using mouse.
After creating a new carte and than clicking back on the Track tree icon, the scrol bar search and highlighting are back.
Any idea what else can I do to reproduce the issue.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2018-12-20T17:35:45Z


hmm the main issue here seems to be that my mouse makes the current not-yet-focused table view jump ~20 lines up as soon as I use the mouse scroll wheel; I noticed this behaviour in other apps, as well.

The second issue is that the track selection is gone (while the scroll position is kept) when I focus the table again via controller or Tab key. If I press Up/Down keys or scroll with controller encoder, the first track is selected which makes the scroll position jump to the top.

I think I'll split this one into multiple bugs.
The tracks table losing focus when I just want to rename (not view) a playlist/crate or create a new on is annoying, because I'll have to scroll up in tree view to get back to Tracks, for example.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2019-01-07T16:38:41Z


I updated the report, it now just describes the scroll position jump when using a controller.

The other aspect of this is in lp:1810810

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2019-09-11T18:22:37Z


I can confirm this. I t happens also if you use the up and down keys on keyboard.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2019-09-14T19:26:39Z


the reason seems to be that the first table cell is somehow focused and the selection jumps there when keys or selection controls attempt to move it.

noticed with https://bugs.launchpad.net/mixxx/+bug/1808632
" can't focus tracks table item if there is only one "

I'm trying to save/restore also the selection focus it when re-activating a library view.
this wouldn work if multiple rows are selected, but I guess that's okay.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-09-03T09:43:00Z


It this fixed now or in progress by one of the related PRs?

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-09-28T01:03:52Z


stalled.
#2378

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2021-01-30T21:27:19Z


superseded by poelzi's #3063

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2021-09-27T00:33:12Z


PR with library selection commits of #⁠3063
#4177

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant