Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve rendering of dark overview markers #9730

Closed
mixxxbot opened this issue Aug 23, 2022 · 5 comments
Closed

improve rendering of dark overview markers #9730

mixxxbot opened this issue Aug 23, 2022 · 5 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: ronso0
Date: 2019-09-02T16:09:48Z
Status: Fix Released
Importance: Undecided
Launchpad Issue: lp1842338
Tags: gui, overview
Attachments: marker-contrast.png, overview_hotcue_markers_glitch.png


dark colors of overview markers are enclosed by contrasting lines to guarantee visibility on the waveforms.
unfortunately, those lines increase the ontrast too much so that the enclosing lines appears like range marks. see attached screenshot

@mixxxbot mixxxbot added the gui label Aug 23, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2019-09-02T16:09:48Z
Attachments: marker-contrast.png

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-08-06T00:57:06Z
Attachments: overview_hotcue_markers_glitch.png


turns out it's just/also a rounding issue, see new screenshot.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-08-06T02:24:49Z


... where hotcues 1 and 2 have the same color.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-09-01T21:34:59Z


#3003

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant