Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beatloop_activate button does not cancel active loop #9950

Closed
mixxxbot opened this issue Aug 23, 2022 · 8 comments
Closed

beatloop_activate button does not cancel active loop #9950

mixxxbot opened this issue Aug 23, 2022 · 8 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: pestrela
Date: 2020-04-29T23:44:34Z
Status: Fix Committed
Importance: Medium
Launchpad Issue: lp1876003
Tags: easy, looping, usability


Loops

  • loop button: always sets and resets a loop. If a loop is active it should deactivate the current one
  • reloop button: this is the one that actually cancels loops

https://www.mixxx.org/forums/viewtopic.php?f=1&t=13355

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-04-30T05:53:33Z


Please add a step by step recipe. What did you do, what is the responds form Mixxx and what should be the responds.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2020-04-30T06:07:08Z


I'm not sure what else there is to say. The first post explains it.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-04-30T06:44:15Z


Do you mean the "beatloop_activate" button?
I think it could work to turn it into a "beatloop_toggle" button, that lights up like the "beatloop_x_toggle" buttons.

@mixxxbot
Copy link
Collaborator Author

Commented by: raphaelquast
Date: 2021-09-13T20:32:50Z


hey, I just wanted to join in to this discussion since I stumbled upon the very same problem...

I've tried to configure a "beatloop_toggle" button but apparently this option does not seem to exist in Mixxx v2.3.0 (even though the doc claims that there is such an option)

Aside of that I experience the same behaviour as described by the OP... the "beatloop_activate" option does not deactivate an already activated loop (it only shifts the loop to the current playback position)

any chance of getting an actual "beatloop_toggle" option that does the following:

  • if a loop is active, deactivate it
  • if no loop is active, activate a beatloop at the current playback position

thanks!

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2021-09-13T21:16:10Z


Yes we were just discussing this recently. Would you like to implement this?

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2021-10-26T21:43:05Z


@onurtuna-lj
In case you're not "fellock" take a look at the WIP pull request
#4328

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2021-10-28T00:42:55Z


Ah sorry, I forgot someone else had already started working on this.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Committed.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant