Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroy PlayerInfo after EngineRecord is stopped to fix a debug assertion #12341

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Destroy PlayerInfo after EngineRecord is stopped to fix a debug assertion #12341

merged 1 commit into from
Nov 23, 2023

Conversation

daschuer
Copy link
Member

This fixes #12242

@daschuer daschuer mentioned this pull request Nov 22, 2023
Closed
@daschuer daschuer changed the base branch from main to 2.4 November 23, 2023 00:03
@daschuer daschuer changed the base branch from 2.4 to main November 23, 2023 00:04
@daschuer daschuer changed the base branch from main to 2.4 November 23, 2023 00:05
ronso0
ronso0 reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the comment can be improved a bit.

src/coreservices.cpp Outdated Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Nov 23, 2023

@uklotzde please take a look.

uklotzde
uklotzde reviewed Nov 23, 2023
View reviewed changes
src/coreservices.cpp Outdated Show resolved Hide resolved
@daschuer
Copy link
Member Author

Done

@ronso0
Copy link
Member

ronso0 commented Nov 23, 2023

Thanks. Squash, then merge?

@daschuer
Copy link
Member Author

Squashed and ready for merge

@ronso0 ronso0 merged commit 174c6d9 into mixxxdj:2.4 Nov 23, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde left review comments

@ronso0 ronso0 ronso0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEBUG ASSERT on shutdown: PlayerInfo::instance()
3 participants
@daschuer @ronso0 @uklotzde