Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--verify doesn't work for checksums if gpg is not installed #616

Open
miyagawa opened this issue Jul 21, 2020 · 0 comments
Open

--verify doesn't work for checksums if gpg is not installed #616

miyagawa opened this issue Jul 21, 2020 · 0 comments

Comments

@miyagawa
Copy link
Owner

miyagawa commented Jul 21, 2020

cpanm's --verify doesn't work, if:

  • Module::Signature is installed
  • gpg is not available in the system

What happens is, If Crypt::OpenPGP is installed, Module::Signature::_verify($chksum) will try to verify the empty string digest and always fail. If Crypt::OpenPGP is not installed, Module::Signature will always succeed, by comparing empty strings.

This is because cpanminus (and CPAN.pm) is using Module::Signature's private API, _verify, and Module::Signature doesn't always read the signature from its argument, depending on the backend it uses.

cc @audreyt @andk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant