Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.toBeGreaterThanOrEqual() #11

Closed
rstacruz opened this issue Jul 4, 2015 · 5 comments
Closed

.toBeGreaterThanOrEqual() #11

rstacruz opened this issue Jul 4, 2015 · 5 comments

Comments

@rstacruz
Copy link
Collaborator

rstacruz commented Jul 4, 2015

It would be nice to have >= and <= assertions.

Also, this alias may be good: .toCompare('>=', 5) (dont know how to name it!)

@mjackson
Copy link
Owner

I think .toBeGreaterThanOrEqualTo is a good name. I'd be happy to accept a PR that does this.

@rstacruz
Copy link
Collaborator Author

I think ...OrEqual is better than ...OrEqualTo though, simply because it keeps parity with .toEqual, but that's just a minor nitpick on my part :)

@mjackson
Copy link
Owner

mjackson commented Oct 6, 2015

Now that we have expect.extend we can leave this up to a 3rd party lib, no? You still want it in core?

Actually, I'm kind of thinking we could refactor our whole library to use extend internally... not sure it would be worth it though.

@rstacruz
Copy link
Collaborator Author

rstacruz commented Oct 6, 2015

I like the idea of using extend() internally, but i'm with you that it's small enough that it doesn't warrant it.

@hrj
Copy link

hrj commented Dec 12, 2015

Would be good to have this.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants