Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expect(null).toEqual(undefined) failing since 1.13.1 #62

Closed
agundermann opened this issue Jan 16, 2016 · 6 comments
Closed

expect(null).toEqual(undefined) failing since 1.13.1 #62

agundermann opened this issue Jan 16, 2016 · 6 comments

Comments

@agundermann
Copy link

This was causing me some issues with rackt/history.

It looks like this test passed before 1.13.1 with deep-equals but fails with is-equal.

I don't know how you want this case to be handled, but since it's a minor version bump, I assume it wasn't intentional. Otherwise, feel free to close.

@mjackson
Copy link
Owner

mjackson commented Feb 1, 2016

I naively assumed that is-equal would handle all the most common cases similarly to deep-equal but I was mistaken. The break wasn't intentional, but now that we've worked out most of the kinks let's just add a test to make our intention clear and close.

@ljharb
Copy link
Collaborator

ljharb commented Feb 11, 2016

null and undefined aren't equal - isn't toEqual like ===?

@mjackson
Copy link
Owner

Yes, it is. We should just add a test here to make that clear and close.

@ljharb
Copy link
Collaborator

ljharb commented Feb 11, 2016

👍

@mjackson
Copy link
Owner

mjackson commented May 7, 2016

Wait, I'm not sure what I was saying here. toEqual should be like ==. toBe is for ===.

@ljharb
Copy link
Collaborator

ljharb commented May 7, 2016

oh right, good point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants