Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ltalloc #2

Open
jlaumon opened this issue Sep 11, 2018 · 3 comments
Open

Adding ltalloc #2

jlaumon opened this issue Sep 11, 2018 · 3 comments

Comments

@jlaumon
Copy link

jlaumon commented Sep 11, 2018

Hey,

I'd be interested in adding ltalloc to your benchmark, but I'm not sure how to do it.

I tried adding the following lines to configure.py but couldn't find how to generate the vcxprojs after that, running configure.py didn't print anything or touch any file as far as I can tell (sorry, I'm a python/ninja noob 😅).

generator.bin(module = 'ltalloc', sources = ['benchmark.c', 'ltalloc.cc'], binname = 'benchmark-ltalloc', basepath = 'benchmark', implicit_deps = [benchmark_lib, test_lib], libs = ['benchmark', 'test'], includepaths = includepaths)

What's the trick? Did I miss something?

Thanks!

@mjansson
Copy link
Owner

That line should generate the needed parts to the ninja build file, just run ninja to build (no need to involve Visual Studio)

@jlaumon
Copy link
Author

jlaumon commented Sep 13, 2018

Ah great, thanks!

Were the visual studio files that are in the repo manually created then?

@mjansson
Copy link
Owner

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants