New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in image_history_buffer #18

Open

davideh29 opened this issue Nov 20, 2018 · 1 comment

davideh29 commented Nov 20, 2018

In "add_to_image_history_buffer" I believe that you have to assign the result of the np.append() to the image buffer array:

self.image_history_buffer = np.append(self.image_history_buffer, images[:nb_to_add], axis=0)

Otherwise the value is not updated. I had to make the change in my implementation to get it to work

Author

davideh29 commented Nov 20, 2018

https://docs.scipy.org/doc/numpy-1.15.0/reference/generated/numpy.append.html

"Note that append does not occur in-place: a new array is allocated and filled"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment