fix: Fix infinite loop inside scanDependency for relative paths start…

…ing with a slash (#988)
mjeanroy · Dec 30, 2021 · f35966e · f35966e
1 parent 7d0f069
commit f35966e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/license-plugin.js b/src/license-plugin.js
@@ -151,7 +151,7 @@ class LicensePlugin {
 
     const scannedDirs = [];
 
-    while (dir && dir !== this._cwd) {
+    while (dir && dir !== this._cwd && !scannedDirs.includes(dir)) {
       // Try the cache.
       if (_.has(this._cache, dir)) {
         pkg = this._cache[dir];

diff --git a/test/license-plugin.spec.js b/test/license-plugin.spec.js
@@ -312,6 +312,12 @@ describe('LicensePlugin', () => {
       expect(plugin._dependencies).toEqual({});
       expect(existsSync).not.toHaveBeenCalled();
     });
+
+    it('should not run into an infinite loop for relative paths starting with a slash', () => {
+      const id = '/abc/efg';
+
+      plugin.scanDependency(id);
+    });
   });
 
   describe('when adding dependencies', () => {