Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use nocase: true for licenseFile #824

Merged
merged 1 commit into from
Jun 2, 2021
Merged

fix: use nocase: true for licenseFile #824

merged 1 commit into from
Jun 2, 2021

Conversation

Luke-zhang-04
Copy link
Contributor

Some dependencies have their LICENSE files named license. The glob pattern doesn't pick up on it unless nocase is true.

@Luke-zhang-04 Luke-zhang-04 changed the title use nocase: true for licenseFile fix: use nocase: true for licenseFile Jun 2, 2021
@mjeanroy
Copy link
Owner

mjeanroy commented Jun 2, 2021

Awesome, thank you!

@mjeanroy mjeanroy merged commit 098fbb0 into mjeanroy:master Jun 2, 2021
mjeanroy pushed a commit that referenced this pull request Jun 6, 2021
@mjeanroy
Copy link
Owner

mjeanroy commented Jun 6, 2021

@Luke-zhang-04 Thanks for your PR, I just released version 2.5.0 with it!

Just for information: nocase: true is broken when using absolute path on Windows (due to the drive prefix, such as C:\), I mitigate it by switching to relative path.

@Luke-zhang-04
Copy link
Contributor Author

Yeah sorry about that. I'm on Linux so I didn't know it was broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants