Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_bytes / with_string method to messages #31

Closed
mjhouse opened this issue Mar 4, 2024 · 0 comments · Fixed by #70
Closed

Add with_bytes / with_string method to messages #31

mjhouse opened this issue Mar 4, 2024 · 0 comments · Fixed by #70
Assignees

Comments

@mjhouse
Copy link
Owner

mjhouse commented Mar 4, 2024

These methods should allow users to bulk-add data words up to 64 bytes total, or 32 data words. the with_bytes, set_bytes and add_bytes methods would have the following signatures:

pub fn with_bytes(mut self, data: &[8]) -> Result<Self>;
pub fn set_bytes(&mut self, data: &[8]) -> Result<usize>;
pub fn add_bytes(&mut self, data: &[8]) -> Result<usize>;

The with_string, set_string, and add_string methods would be similar but take a &str param.

@mjhouse mjhouse changed the title Add with_data method to add raw binary to messages Add with_bytes / with_string method to messages Mar 5, 2024
@mjhouse mjhouse self-assigned this Mar 10, 2024
@mjhouse mjhouse assigned mjhouse and unassigned mjhouse Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant