-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selected text needs better contrast ratio #78
Comments
Yes. I thought Clouds Midnight just seemed especially bad. Merbivore and a few others seemed kinda iffy at best. We're putting a big focus on accessibility for our website users right now, so maybe my view is just a little slanted at this point. Sorry! |
No pb :) maybe the default theme in mjml-app can be changed to a more accessible one. |
I might go with that Cobalt suggestion you first made. I'm still a bit of a n00b at this and admittedly didn't go through EVERY theme, but I think Cobalt has some decent contrast going on—I assume we're only talking about dark themes (I had no issue with the white background on the lighter ones). I used http://colorsafe.co/ to approximate a few colors from the app theme and see where the ratios stacked up. Obviously a few different colors to take into consideration, but I think it seemed OK. We're borrowing heavily from 18F and making a few modifications where needed to craft our own accessibility standards. Our own color specs are listed at https://web.wsu.edu/guides/accessibility/color-and-contrast/. |
Selected text needs greater contrast when code is displayed on a dark background. It's not easy to distinguish which lines of code have been highlighted and which ones have not. See screenshot below.
The text was updated successfully, but these errors were encountered: