Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected text needs better contrast ratio #78

Closed
jbickelhaupt opened this issue Feb 16, 2017 · 4 comments
Closed

Selected text needs better contrast ratio #78

jbickelhaupt opened this issue Feb 16, 2017 · 4 comments
Labels

Comments

@jbickelhaupt
Copy link
Contributor

Selected text needs greater contrast when code is displayed on a dark background. It's not easy to distinguish which lines of code have been highlighted and which ones have not. See screenshot below.

image

@meriadec
Copy link
Contributor

Hi, you can change the editor theme in the editor settings, see for example the 'Cobalt' one:

screen shot 2017-02-16 at 19 33 57

@jbickelhaupt
Copy link
Contributor Author

Yes. I thought Clouds Midnight just seemed especially bad. Merbivore and a few others seemed kinda iffy at best. We're putting a big focus on accessibility for our website users right now, so maybe my view is just a little slanted at this point. Sorry!

@meriadec
Copy link
Contributor

No pb :) maybe the default theme in mjml-app can be changed to a more accessible one.
In your opinion, which one will be the best compromise between accessibility & good integration with app design?

@jbickelhaupt
Copy link
Contributor Author

I might go with that Cobalt suggestion you first made. I'm still a bit of a n00b at this and admittedly didn't go through EVERY theme, but I think Cobalt has some decent contrast going on—I assume we're only talking about dark themes (I had no issue with the white background on the lighter ones).

I used http://colorsafe.co/ to approximate a few colors from the app theme and see where the ratios stacked up. Obviously a few different colors to take into consideration, but I think it seemed OK.

We're borrowing heavily from 18F and making a few modifications where needed to craft our own accessibility standards. Our own color specs are listed at https://web.wsu.edu/guides/accessibility/color-and-contrast/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants