Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code cleanup] - Simplify workbench fields implementation #755

Closed
joecorall opened this issue Mar 19, 2024 · 1 comment
Closed

[code cleanup] - Simplify workbench fields implementation #755

joecorall opened this issue Mar 19, 2024 · 1 comment
Labels
code cleanup Clean up code, including code-level comments documentation Improvements or additions to documentation

Comments

@joecorall
Copy link
Contributor

The Workbench fields logic has some duplicate logic to handle Drupal field cardinality and CSV cell sub-delimiters. We can simplify the implementation by having the logic handle both cases in the same code block.
@joecorall joecorall mentioned this issue Mar 19, 2024
Merged
6 tasks
@mjordan
Copy link
Owner

mjordan commented Mar 19, 2024

Was reviewing this PR this morning, it's a major improvement. Will likely merge this evening.

@mjordan mjordan added documentation Improvements or additions to documentation code cleanup Clean up code, including code-level comments labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code cleanup Clean up code, including code-level comments documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjordan @joecorall