Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to merge multiple subtitle images contained in one subPictureBD structure #39

Open
hellishfire opened this issue Jan 31, 2013 · 4 comments

Comments

@hellishfire
Copy link

When converting one bluray sup file recently, I noticed that the ouput idx/sub file contains incomplete subtitles for certain lines.

After single-stepping through the source code, I found out that when decoding images, only the first imageObject in a subPictureBD instance was decoded. This led to incomplete subtitle since in my case, there were sometimes two imageObject in one subPictureBD. I believe these two imageObject should be combined to form one complete subtitle image.

I'm not a Java programmer, so I suppose I will just post this issue here instead of trying to fix this bug myself. I can provide the sup file in question if further inspection is needed.

@amichaelt
Copy link

Yes, that is the problem with the code. It always only assumed one image object. It's the same reason the avatar bluray SUP from: #34 crashes the program. I'm sure another SUP file to help fix the issue and test would be helpful.

@ghost
Copy link

ghost commented Mar 18, 2013

Miklos, another good test file for multi-region subtitles is here: https://www.dropbox.com/s/yi08oqi3jtbfrdl/Ouran1a.7z That exposed a number of bugs in the multi-region parsing support I added.

@mjuhasz
Copy link
Owner

mjuhasz commented Mar 18, 2013

Got it, thank you! I am quite busy these days but I certainly downloaded your file and will look into it later.

@xwlcn
Copy link

xwlcn commented Jun 12, 2022

It seems that the author has not maintained for a long time, and the issue has not been fixed.

So I finished this work, You can be found here: https://github.com/xwlcn/BDSupSubPlus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants