Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Escaping of Content #75

Open
mkaz opened this issue Jun 23, 2020 · 4 comments
Open

Add Escaping of Content #75

mkaz opened this issue Jun 23, 2020 · 4 comments

Comments

@mkaz
Copy link
Owner

mkaz commented Jun 23, 2020

See: westonruter/syntax-highlighting-code-block#118
@westonruter
Copy link
Contributor

Humm. Somehow it seems that now doing <code>{escape(attributes.content)}</code> is double-escaping the content. It's causing block validation errors now in syntax-highlighting-code-block. Is the content now getting pre-escaped somehow?

@westonruter
Copy link
Contributor

Opened an issue to investigate: westonruter/syntax-highlighting-code-block#201

@westonruter
Copy link
Contributor

It appears due to WordPress/gutenberg#24689.

@westonruter
Copy link
Contributor

westonruter commented Oct 26, 2020 •
edited
Loading

I've added what I believe is the required escaping logic in westonruter/syntax-highlighting-code-block#200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkaz @westonruter