Merge pull request #3784 from squidfunk/fix/docker-warning

Fix strict mode in Docker by removing 0.0.0.0 warning

Author: tomchristie

mkdocs/config/config_options.py

@@ -488,16 +488,6 @@ def run_validation(self, value: object) -> _IpAddressValue:
 
         return _IpAddressValue(host, port)
 
-    def post_validation(self, config: Config, key_name: str):
-        host = config[key_name].host
-        if key_name == 'dev_addr' and host in ['0.0.0.0', '::']:
-            self.warnings.append(
-                f"The use of the IP address '{host}' suggests a production environment "
-                "or the use of a proxy to connect to the MkDocs server. However, "
-                "the MkDocs' server is intended for local development purposes only. "
-                "Please use a third party production-ready server instead."
-            )
-
 
 class URL(OptionallyRequired[str]):
     """

mkdocs/tests/config/config_options_legacy_tests.py

@@ -351,6 +351,28 @@ class Schema:
         self.assertEqual(conf['option'].host, '127.0.0.1')
         self.assertEqual(conf['option'].port, 8000)
 
+    def test_bind_all_IPv4_address(self):
+        addr = '0.0.0.0:8000'
+
+        class Schema:
+            option = c.IpAddress(default=addr)
+
+        conf = self.get_config(Schema, {'option': None})
+        self.assertEqual(str(conf['option']), addr)
+        self.assertEqual(conf['option'].host, '0.0.0.0')
+        self.assertEqual(conf['option'].port, 8000)
+
+    def test_bind_all_IPv6_address(self):
+        addr = ':::8000'
+
+        class Schema:
+            option = c.IpAddress(default=addr)
+
+        conf = self.get_config(Schema, {'option': None})
+        self.assertEqual(str(conf['option']), addr)
+        self.assertEqual(conf['option'].host, '::')
+        self.assertEqual(conf['option'].port, 8000)
+
     @unittest.skipIf(
         sys.version_info < (3, 9, 5),
         "Leading zeros allowed in IP addresses before Python3.9.5",
@@ -381,37 +403,6 @@ def test_invalid_address_missing_port(self):
         with self.expect_error(option="Must be a string of format 'IP:PORT'"):
             self.get_config(self.Schema, {'option': '127.0.0.1'})
 
-    def test_unsupported_address(self):
-        class Schema:
-            dev_addr = c.IpAddress()
-
-        self.get_config(
-            Schema,
-            {'dev_addr': '0.0.0.0:8000'},
-            warnings=dict(
-                dev_addr="The use of the IP address '0.0.0.0' suggests a production "
-                "environment or the use of a proxy to connect to the MkDocs "
-                "server. However, the MkDocs' server is intended for local "
-                "development purposes only. Please use a third party "
-                "production-ready server instead."
-            ),
-        )
-
-    def test_unsupported_IPv6_address(self):
-        class Schema:
-            dev_addr = c.IpAddress()
-
-        self.get_config(
-            Schema,
-            {'dev_addr': ':::8000'},
-            warnings=dict(
-                dev_addr="The use of the IP address '::' suggests a production environment "
-                "or the use of a proxy to connect to the MkDocs server. However, "
-                "the MkDocs' server is intended for local development purposes "
-                "only. Please use a third party production-ready server instead."
-            ),
-        )
-
 
 class URLTest(TestCase):
     def test_valid_url(self):

mkdocs/tests/config/config_options_tests.py

@@ -339,6 +339,28 @@ class Schema(Config):
         self.assertEqual(conf.option.host, '127.0.0.1')
         self.assertEqual(conf.option.port, 8000)
 
+    def test_bind_all_IPv4_address(self):
+        addr = '0.0.0.0:8000'
+
+        class Schema(Config):
+            option = c.IpAddress(default=addr)
+
+        conf = self.get_config(Schema, {'option': None})
+        self.assertEqual(str(conf['option']), addr)
+        self.assertEqual(conf['option'].host, '0.0.0.0')
+        self.assertEqual(conf['option'].port, 8000)
+
+    def test_bind_all_IPv6_address(self):
+        addr = ':::8000'
+
+        class Schema(Config):
+            option = c.IpAddress(default=addr)
+
+        conf = self.get_config(Schema, {'option': None})
+        self.assertEqual(str(conf['option']), addr)
+        self.assertEqual(conf['option'].host, '::')
+        self.assertEqual(conf['option'].port, 8000)
+
     @unittest.skipIf(
         sys.version_info < (3, 9, 5),
         "Leading zeros allowed in IP addresses before Python3.9.5",
@@ -369,37 +391,6 @@ def test_invalid_address_missing_port(self) -> None:
         with self.expect_error(option="Must be a string of format 'IP:PORT'"):
             self.get_config(self.Schema, {'option': '127.0.0.1'})
 
-    def test_unsupported_address(self) -> None:
-        class Schema(Config):
-            dev_addr = c.IpAddress()
-
-        self.get_config(
-            Schema,
-            {'dev_addr': '0.0.0.0:8000'},
-            warnings=dict(
-                dev_addr="The use of the IP address '0.0.0.0' suggests a production "
-                "environment or the use of a proxy to connect to the MkDocs "
-                "server. However, the MkDocs' server is intended for local "
-                "development purposes only. Please use a third party "
-                "production-ready server instead."
-            ),
-        )
-
-    def test_unsupported_IPv6_address(self) -> None:
-        class Schema(Config):
-            dev_addr = c.IpAddress()
-
-        self.get_config(
-            Schema,
-            {'dev_addr': ':::8000'},
-            warnings=dict(
-                dev_addr="The use of the IP address '::' suggests a production environment "
-                "or the use of a proxy to connect to the MkDocs server. However, "
-                "the MkDocs' server is intended for local development purposes "
-                "only. Please use a third party production-ready server instead."
-            ),
-        )
-
 
 class URLTest(TestCase):
     def test_valid_url(self) -> None: