Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROPBEAR_SVR_MULTIUSER sanity check false positive fail #214

Closed
davidatrsp opened this issue Jan 17, 2023 · 1 comment
Closed

DROPBEAR_SVR_MULTIUSER sanity check false positive fail #214

davidatrsp opened this issue Jan 17, 2023 · 1 comment
Labels

Comments

@davidatrsp
Copy link

Hejsa
Disabling DROPBEAR_SVR_MULTIUSER config on kernel 5.10 without CONFIG_MULTIUSER produces a failed sanity check when initiation a session.
Traced the issue down to

getuid();
. The "getuid()" doesn't set errno to "ENOSYS" as expected.
Looked into the kernel source and looks like "getuid()" syscall is always present, independently of CONFIG_MULTIUSER. Also, when CONFIG_MULTIUSER is disabled "getuid()" always succeeds and returns "0". This behaviour is present at leats from kernel 4.9.
My workaround is to change "getuid" syscall into "getgroups". The "getgroups" has the expected behaviour, it is only present when the kernel is configured with CONFIG_MULTIUSER.

@mkj
Copy link
Owner

mkj commented Jan 18, 2023

Thanks, I'll fix that. I wonder if that means no one has used the disabled-DROPBEAR_SVR_MULTIUSER functionality since it was added...

@mkj mkj added the bug label Jan 18, 2023
@mkj mkj closed this as completed in 9ac6504 Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants