fix specs

Author: mkon

spec/api_valve/forwarder/response_spec.rb

@@ -10,7 +10,7 @@
       'HTTP_X_FORWARDED_FOR'   => '212.122.121.211',
       'HTTP_X_FORWARDED_HOST'  => host,
       'HTTP_X_FORWARDED_PORT'  => '443',
-      'HTTP_X_FORWARDED_PROTO' => scheme,
+      'HTTP_X_FORWARDED_PROTO' => 'https',
       'HTTP_USER_AGENT'        => 'Faraday',
       'HTTP_OTHER_HEADER'      => 'Ignored'
     }
@@ -20,11 +20,12 @@
       response_headers: response_headers,
       status: 301,
       response_body: nil,
-      url: URI.join("#{scheme}://#{host}", *[remote_prefix.presence, remote_path].compact)
+      url: URI.join("https://#{host}", *[remote_prefix.presence, remote_path].compact)
     }
   end
   let(:host) { 'api.example.com' }
   let(:local_prefix) { '/proxy-prefix' }
+  let(:location) { nil }
   let(:options) do
     {
       target_prefix: remote_prefix,
@@ -35,36 +36,51 @@
   let(:remote_prefix) { '/remote-prefix' }
   let(:remote_path) { 'remote-path' }
   let(:response_headers) do
-    {'Location' => '/remote-prefix/see/other/path'}
+    {'Location' => location.presence}.compact
   end
   let(:rack_response) { response.rack_response }
-  let(:scheme) { 'https' }
-  let(:headers) { rack_response.headers }
 
   describe 'Location header' do
-    subject { headers['Location'] }
+    subject { rack_response.location }
 
     context 'when both remote and local have a prefix' do
+      let(:location) { '/remote-prefix/original-redirect' }
       let(:local_prefix) { '/proxy-prefix' }
       let(:remote_prefix) { '/remote-prefix' }
 
-      it { is_expected.to eq '/proxy-prefix/see/other/path' }
+      it { is_expected.to eq '/proxy-prefix/original-redirect' }
     end
 
     context 'when only remote has a prefix' do
+      let(:location) { '/remote-prefix/original-redirect' }
       let(:local_prefix) { '' }
       let(:remote_prefix) { '/remote-prefix' }
 
-      it { is_expected.to eq '/see/other/path' }
+      it { is_expected.to eq '/original-redirect' }
     end
 
     context 'when only local has a prefix' do
+      let(:location) { '/original-redirect' }
       let(:local_prefix) { '/local-prefix' }
-      let(:response_headers) do
-        {'Location' => '/see/other/path'}
-      end
+      let(:remote_prefix) { '' }
 
-      it { is_expected.to eq '/proxy-prefix/see/other/path' }
+      it { is_expected.to eq '/local-prefix/original-redirect' }
+    end
+
+    context 'when neither has a prefix' do
+      let(:location) { '/original-redirect' }
+      let(:local_prefix) { '' }
+      let(:remote_prefix) { '' }
+
+      it { is_expected.to eq location }
+    end
+
+    context 'when it points to a different host' do
+      let(:location) { 'https://otherhost.com/original-redirect' }
+      let(:local_prefix) { '/proxy-prefix' }
+      let(:remote_prefix) { '/remote-prefix' }
+
+      it { is_expected.to eq location }
     end
   end
 end