-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ViT + CLIP #143
Comments
Yea that ones on our list of examples to add! Are you interested in contributing it? If so which model would you use? |
I would like to contribute :) However, I would like to complete the implementation of norm first (ml-explore/mlx#187). I would use models from the official CLIP repository: https://github.com/openai/CLIP. If you have an alternative idea, please let me know. |
@gboduljak I submitted a PR to your existing PR, which creates a local implementation of the CLIPImageProcessor. gboduljak#1 This should eliminate the dependency on transformers, aside from using it for downloading the model & tokenizer. |
@nkasmanoff Thanks for the help. I will take a look at your work now. |
@nkasmanoff I merged your PR, corrected the nits and I refactored your implementation so that everything is in |
Would it be worth implementing ViT and CLIP example?
The text was updated successfully, but these errors were encountered: