Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit forwardRef #13

Closed
jchavarri opened this issue May 29, 2019 · 0 comments · Fixed by #19
Closed

Revisit forwardRef #13

jchavarri opened this issue May 29, 2019 · 0 comments · Fixed by #19
Assignees
@jchavarri

Comments

@jchavarri
Copy link
Collaborator

As @benschinn noticed I left an unused var the forwardRef implementation. Needs more thought / testing, via React.useRef, to make sure all things are working correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jchavarri jchavarri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix forwardRef unsafety + make DOM refs types more idiomatic ml-in-barcelona/jsoo-react
1 participant
@jchavarri