Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit with pylint check #3

Merged
merged 6 commits into from
Mar 8, 2023
Merged

Conversation

RobbeSneyders
Copy link
Member

This PR sets up pre-commit for a smooth developer flow:

  • Adds pre-commit with a pylint check
    We can extend this further with additional checks.
  • Fix the issues detected by the pylint check
  • Add a github action to run pre-commit on each PR and on merges to main

README.md Outdated Show resolved Hide resolved
Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com>
Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving!

@RobbeSneyders RobbeSneyders merged commit a3b1677 into main Mar 8, 2023
PhilippeMoussalli added a commit that referenced this pull request Mar 14, 2023
This PR sets up pre-commit for a smooth developer flow:
- Adds pre-commit with a pylint check
  We can extend this further with additional checks.
- Fix the issues detected by the pylint check
- Add a github action to run pre-commit on each PR and on merges to main
@RobbeSneyders RobbeSneyders deleted the feature/pre-commit branch May 15, 2023 16:30
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
This PR sets up pre-commit for a smooth developer flow:
- Adds pre-commit with a pylint check
  We can extend this further with additional checks.
- Fix the issues detected by the pylint check
- Add a github action to run pre-commit on each PR and on merges to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants