Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failure on latest rust nightly #13

Closed
rossmuir opened this issue Aug 31, 2015 · 4 comments
Closed

Compilation failure on latest rust nightly #13

rossmuir opened this issue Aug 31, 2015 · 4 comments

Comments

@rossmuir
Copy link

https://travis-ci.org/mlalic/solicit/jobs/78031248

@mlalic
Copy link
Owner

mlalic commented Aug 31, 2015

Thanks for the quick reaction times! :)

I consider this to be some fairly strange behavior by rustc, as the read_exact feature is not turned on by the crate, so I wouldn't expect the compiler to even consider using the method. I've already asked about this under rust-lang/rust#28126.

In the short term, the method can be renamed directly invoked from the TransportStream trait namespace to fix the conflict

In the long term, the custom read_exact extension will no longer be necessary and should be removed in favor of the official io::Read method...

@mlalic mlalic closed this as completed in caa1e95 Aug 31, 2015
@rossmuir
Copy link
Author

Thank you

@mlalic
Copy link
Owner

mlalic commented Aug 31, 2015

The new version (0.4.3) working around this is up on crates.io, by the way!

@bonifaido
Copy link

This was insanely fast! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants